Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schedules.md #5826

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update schedules.md #5826

merged 1 commit into from
Oct 15, 2024

Conversation

RaghavMangla
Copy link
Contributor

@RaghavMangla RaghavMangla commented Oct 8, 2024 •
edited
Loading

Why are the changes needed?

delete documentation related to AWS scheduler configuration, as the flyte native scheduler should just work.

reference slack thread: https://discuss.flyte.org/t/15852550/hi-team-i-have-created-a-simple-test-flyte-scheduler-using-b#929e7edd-c801-4dbb-bdbf-61cb36903727

Issue Link: #4513
Closes #4513

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

Changes made in schedules.md: https://github.com/flyteorg/flyte/edit/master/docs/user_guide/productionizing/schedules.md

@RaghavMangla
Update schedules.md
622d874 
delete documentation related to AWS scheduler configuration, as the flyte native scheduler should just work.

reference slack thread: https://discuss.flyte.org/t/15852550/hi-team-i-have-created-a-simple-test-flyte-scheduler-using-b#929e7edd-c801-4dbb-bdbf-61cb36903727

Signed-off-by: Raghav Mangla <[email protected]>
@welcome Welcome
Copy link

welcome bot commented Oct 8, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@RaghavMangla RaghavMangla mentioned this pull request Oct 8, 2024
Closed
2 tasks
@RaghavMangla
Copy link
Contributor Author

@neverett @ppiegaze @samhita-alla pls review this pr

@neverett
Copy link
Contributor

neverett commented Oct 9, 2024

This looks good to me, but @samhita-alla I wanted to double check what you meant by "move to the legacy section" in the linked issue -- do you think this content should remain on the page, just under a "Legacy" heading?

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.35%. Comparing base (604be4a) to head (622d874).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5826   +/-   ##
=======================================
  Coverage   36.35%   36.35%           
=======================================
  Files        1304     1304           
  Lines      110147   110147           
=======================================
+ Hits        40041    40042    +1     
+ Misses      65939    65938    -1     
  Partials     4167     4167
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaghavMangla
Copy link
Contributor Author

Hi! @neverett actually in this issue #4513 it was mentioned to delete the aws scheduler part in documentation, so i removed that part from documentation

@RaghavMangla
Copy link
Contributor Author

@neverett @ppiegaze pls review the PR

@RaghavMangla
Copy link
Contributor Author

RaghavMangla commented Oct 12, 2024 •
edited
Loading

All checks have passed , please let me know if any changes are required
@neverett @ppiegaze

@samhita-alla
Copy link
Contributor

@neverett i think it should be okay to delete the docs. we don't need to preserve it anymore.

@samhita-alla samhita-alla merged commit 3523326 into flyteorg:master Oct 15, 2024
49 checks passed
@welcome Welcome
Copy link

welcome bot commented Oct 15, 2024

Congrats on merging your first pull request! 🎉

@allcontributors AllContributors
Copy link

@RaghavMangla

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@RaghavMangla
Copy link
Contributor Author

RaghavMangla commented Oct 15, 2024 •
edited
Loading

@all-contributors please add my github account RaghavMangla for contributions docs
#5826
flyteorg/flytekit#2791
flyteorg/flytesnacks#1742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhita-alla samhita-alla samhita-alla approved these changes

@neverett neverett Awaiting requested review from neverett

@ppiegaze ppiegaze Awaiting requested review from ppiegaze ppiegaze is a code owner

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] move aws scheduler docs to the legacy section
3 participants
@RaghavMangla @neverett @samhita-alla